Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Replace .ix usage #3525

Merged
merged 1 commit into from Mar 5, 2017
Merged

FIX: Replace .ix usage #3525

merged 1 commit into from Mar 5, 2017

Conversation

bashtage
Copy link
Member

@bashtage bashtage commented Mar 1, 2017

.ix is deprecated. Replace with correct loc/iloc as needed
Change indices to since iloc does not include end point

@bashtage
FIX: Replace .ix usage
74e12d8 
.ix is deprecated.  Replace with correct loc/iloc as needed
Change indices to since iloc does not include end point
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 90.32% when pulling 1408652 on bashtage:remove-ix-pandas into fc045f4 on statsmodels:master.

@TomAugspurger
Copy link
Contributor

This looks good on a quick skim. Didn't see any other .ixes on a grep either. All ready @bashtage?

@bashtage
Copy link
Member Author

bashtage commented Mar 5, 2017

I think it is ready.

@TomAugspurger TomAugspurger merged commit c906881 into statsmodels:master Mar 5, 2017
@TomAugspurger
Copy link
Contributor

Thanks!

@TomAugspurger TomAugspurger mentioned this pull request Mar 5, 2017
Closed
2 tasks
@josef-pkt josef-pkt added this to the 0.9 milestone May 15, 2017
@bashtage bashtage deleted the remove-ix-pandas branch June 23, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bashtage @coveralls @TomAugspurger @josef-pkt