ENH: Add inf/nan protection to regression models #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4969 +/- ##
==========================================
+ Coverage 82% 82.01% +0.01%
==========================================
Files 588 588
Lines 93061 93114 +53
Branches 10313 10321 +8
==========================================
+ Hits 76311 76364 +53
Misses 14378 14378
Partials 2372 2372
Continue to review full report at Codecov.
|
bashtage
force-pushed
the
protect-regressions-inf-nan
branch
from
3637217
to
70e8f30
Compare
|
LGTM. @josef-pkt Travis error is unrelated http error. |
bashtage
force-pushed
the
protect-regressions-inf-nan
branch
from
70e8f30
to
d8c9db3
Compare
bashtage
force-pushed
the
protect-regressions-inf-nan
branch
from
d8c9db3
to
d9ed68c
Compare
|
@josef-pkt this bashtage PR is green and doesn’t need rebase |
bashtage
force-pushed
the
protect-regressions-inf-nan
branch
from
d9ed68c
to
81d5737
Compare
|
needs decision I'm not sure, about whether we want to do this. |
bashtage
force-pushed
the
protect-regressions-inf-nan
branch
from
81d5737
to
895503c
Compare
Add an inf/nan check for regression models closes statsmodels#3468 closes statsmodels#1642
bashtage
force-pushed
the
protect-regressions-inf-nan
branch
from
895503c
to
d789883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an inf/nan check for regression models
closes #3468
closes #1642