New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add penalization summary, closes #5461 #5490
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5490 +/- ##
==========================================
- Coverage 81.99% 81.93% -0.07%
==========================================
Files 586 586
Lines 92275 92289 +14
Branches 10240 9516 -724
==========================================
- Hits 75660 75613 -47
- Misses 14273 14328 +55
- Partials 2342 2348 +6
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #5490 +/- ##
==========================================
- Coverage 81.99% 81.93% -0.07%
==========================================
Files 586 586
Lines 92275 92289 +14
Branches 10240 9516 -724
==========================================
- Hits 75660 75613 -47
- Misses 14273 14328 +55
- Partials 2342 2348 +6
Continue to review full report at Codecov.
|
@josef-pkt the build failure appears to be unrelated to the changes I have made. Is there anything I can do to resolve this? |
Just ignore that failure, as do I for the moment. We have an open issue to fix it. |
The issue is #5457 |
Thanks @josef-pkt @kshedden. Do let me know if there are any changes I should make to the PR. |
@stevenbw The main thing are unit tests and examples to see for which models this works. I only thought about it for a bit. I think we need additional keyword arguments to override that the method of the results instance is used, e.g. I'm not sure how consistent penalization is at the moment across models, or which additional info will be available. edf is effective degrees of freedom which is currently only available in GAM. |
Thanks @josef-pkt, I'll add some unit tests and examples. Do you think it would be better to extend the method for other models with more appropriate summaries in another PR? |
Added the
add_penal_table
method to thesummary
class which collects the penalization information and returns it as a SimpleTable instance.