Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Improve error when ARMA endog is not 1d #5640

Merged
merged 1 commit into from May 7, 2019

Conversation

bashtage
Copy link
Member

@bashtage bashtage commented May 7, 2019

Improve explanation when passing an array that is not 1d or 1 column, 2d

closes #2575

Improve explanation when passing an array that is not 1d or 1 column, 2d

closes statsmodels#2575
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 84.556% when pulling e6e6199 on bashtage:arma-1d-check into 6453c81 on statsmodels:master.

@bashtage bashtage merged commit 41a3b8f into statsmodels:master May 7, 2019
@bashtage bashtage deleted the arma-1d-check branch May 7, 2019 11:49
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #5640 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5640      +/-   ##
==========================================
+ Coverage   82.02%   82.03%   +<.01%     
==========================================
  Files         587      587              
  Lines       93435    93451      +16     
  Branches    10374    10375       +1     
==========================================
+ Hits        76642    76658      +16     
  Misses      14392    14392              
  Partials     2401     2401
Impacted Files Coverage Δ
statsmodels/tsa/arima_model.py 86.91% <100%> (+0.04%) ⬆️
statsmodels/tsa/tests/test_arima.py 99.5% <100%> (ø) ⬆️
statsmodels/tsa/tests/test_holtwinters.py 100% <0%> (ø) ⬆️
statsmodels/regression/tests/test_lme.py 99.46% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6453c81...e6e6199. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARIMA: Check if input dataframe has one column
2 participants