Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: fix non-working example ex_pandas #5717

Merged
merged 1 commit into from May 14, 2019

Conversation

jbrockmendel
Copy link
Contributor

A couple of usages were out of date:

  • an incorrect frequency passed to VAR raised, so this now passes the correct frequency.
  • order was passed to ARMA.fit instead of to the ARMA constructor, which raises, so this passes it in the up-to-date signature.

A couple of things were commented out, and one docstring'd-out traceback for things that used to fail or not exist. These are now printed like everything else as they now work.

@jbrockmendel
Copy link
Contributor Author

Closes #5690

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 84.726% when pulling 442b864 on jbrockmendel:exescapes4 into 37e3fe8 on statsmodels:master.

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #5717 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5717   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files         593      593           
  Lines       93717    93717           
  Branches    10353    10353           
=======================================
  Hits        77059    77059           
  Misses      14257    14257           
  Partials     2401     2401

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37e3fe8...442b864. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #5717 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5717   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files         593      593           
  Lines       93717    93717           
  Branches    10353    10353           
=======================================
  Hits        77059    77059           
  Misses      14257    14257           
  Partials     2401     2401

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37e3fe8...442b864. Read the comment docs.

Copy link
Member

@bashtage bashtage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants