CLN: Replace #5779 #5781
Merged
CLN: Replace #5779 #5781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5781 +/- ##
==========================================
+ Coverage 82.4% 82.41% +<.01%
==========================================
Files 594 594
Lines 93748 93794 +46
Branches 10357 10352 -5
==========================================
+ Hits 77250 77296 +46
+ Misses 14100 14099 -1
- Partials 2398 2399 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #5781 +/- ##
==========================================
+ Coverage 82.4% 82.41% +<.01%
==========================================
Files 594 594
Lines 93748 93794 +46
Branches 10357 10352 -5
==========================================
+ Hits 77250 77296 +46
+ Misses 14100 14099 -1
- Partials 2398 2399 +1
Continue to review full report at Codecov.
|
|
Random fail. Just merged patch to protect against this |
ChadFulton
reviewed
May 25, 2019
| @@ -266,7 +277,7 @@ def partial_transform_sigma2(sigma2): | |||
| approx_fd_centered = ( | |||
| mod.score(uparams, transformed=False, approx_complex_step=False, | |||
| approx_centered=True)) | |||
| assert_allclose(approx_fd, analytic_score, atol=1e-5) | |||
| assert_allclose(approx_fd_centered, analytic_score, atol=1e-5) | |||
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChadFulton the bare minimum to get linter to pass on statespace/tests. There were a few places where changing assert_raises to pytest.raises was the best way to fix a linting complaint, but I didn't make that change in any other places, so the usage is still plenty mixed.