REF/CLN: collect imports at top of file, de-duplicate imports #5805

jbrockmendel · 2019-05-29T04:36:15Z

No description provided.

pep8speaks · 2019-05-29T04:36:45Z

Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-05-29 04:42:47 UTC

coveralls · 2019-05-29T07:14:19Z

Coverage decreased (-0.004%) to 84.986% when pulling b65c971 on jbrockmendel:E4 into 321619e on statsmodels:master.

codecov · 2019-05-29T07:14:26Z

Codecov Report

Merging #5805 into master will increase coverage by <.01%.
The diff coverage is 54.05%.

@@            Coverage Diff             @@
##           master    #5805      +/-   ##
==========================================
+ Coverage   82.46%   82.47%   +<.01%     
==========================================
  Files         595      595              
  Lines       93776    93765      -11     
  Branches    10353    10353              
==========================================
- Hits        77333    77328       -5     
+ Misses      14046    14040       -6     
  Partials     2397     2397

Impacted Files	Coverage Δ
statsmodels/sandbox/distributions/transformed.py	`0% <ø> (ø)`	⬆️
statsmodels/sandbox/archive/tsa.py	`0% <ø> (ø)`	⬆️
statsmodels/tsa/coint_tables.py	`82.05% <ø> (ø)`	⬆️
statsmodels/sandbox/archive/linalg_covmat.py	`0% <0%> (ø)`	⬆️
.../sandbox/distributions/examples/ex_mvelliptical.py	`0% <0%> (ø)`	⬆️
...atsmodels/sandbox/regression/ols_anova_original.py	`0% <0%> (ø)`	⬆️
statsmodels/sandbox/tsa/example_arma.py	`0% <0%> (ø)`	⬆️
statsmodels/sandbox/tsa/try_var_convolve.py	`0% <0%> (ø)`	⬆️
...tsmodels/sandbox/nonparametric/densityorthopoly.py	`0% <0%> (ø)`	⬆️
statsmodels/sandbox/distributions/genpareto.py	`0% <0%> (ø)`	⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321619e...b65c971. Read the comment docs.

codecov · 2019-05-29T07:14:26Z

Codecov Report

Merging #5805 into master will increase coverage by <.01%.
The diff coverage is 54.05%.

@@            Coverage Diff             @@
##           master    #5805      +/-   ##
==========================================
+ Coverage   82.46%   82.47%   +<.01%     
==========================================
  Files         595      595              
  Lines       93776    93765      -11     
  Branches    10353    10353              
==========================================
- Hits        77333    77328       -5     
+ Misses      14046    14040       -6     
  Partials     2397     2397

Impacted Files	Coverage Δ
statsmodels/sandbox/distributions/transformed.py	`0% <ø> (ø)`	⬆️
statsmodels/sandbox/archive/tsa.py	`0% <ø> (ø)`	⬆️
statsmodels/tsa/coint_tables.py	`82.05% <ø> (ø)`	⬆️
statsmodels/sandbox/archive/linalg_covmat.py	`0% <0%> (ø)`	⬆️
.../sandbox/distributions/examples/ex_mvelliptical.py	`0% <0%> (ø)`	⬆️
...atsmodels/sandbox/regression/ols_anova_original.py	`0% <0%> (ø)`	⬆️
statsmodels/sandbox/tsa/example_arma.py	`0% <0%> (ø)`	⬆️
statsmodels/sandbox/tsa/try_var_convolve.py	`0% <0%> (ø)`	⬆️
...tsmodels/sandbox/nonparametric/densityorthopoly.py	`0% <0%> (ø)`	⬆️
statsmodels/sandbox/distributions/genpareto.py	`0% <0%> (ø)`	⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321619e...b65c971. Read the comment docs.

codecov · 2019-05-29T07:14:26Z

Codecov Report

Merging #5805 into master will increase coverage by <.01%.
The diff coverage is 54.05%.

@@            Coverage Diff             @@
##           master    #5805      +/-   ##
==========================================
+ Coverage   82.46%   82.47%   +<.01%     
==========================================
  Files         595      595              
  Lines       93776    93765      -11     
  Branches    10353    10353              
==========================================
- Hits        77333    77328       -5     
+ Misses      14046    14040       -6     
  Partials     2397     2397

Impacted Files	Coverage Δ
statsmodels/sandbox/distributions/transformed.py	`0% <ø> (ø)`	⬆️
statsmodels/sandbox/archive/tsa.py	`0% <ø> (ø)`	⬆️
statsmodels/tsa/coint_tables.py	`82.05% <ø> (ø)`	⬆️
statsmodels/sandbox/archive/linalg_covmat.py	`0% <0%> (ø)`	⬆️
.../sandbox/distributions/examples/ex_mvelliptical.py	`0% <0%> (ø)`	⬆️
...atsmodels/sandbox/regression/ols_anova_original.py	`0% <0%> (ø)`	⬆️
statsmodels/sandbox/tsa/example_arma.py	`0% <0%> (ø)`	⬆️
statsmodels/sandbox/tsa/try_var_convolve.py	`0% <0%> (ø)`	⬆️
...tsmodels/sandbox/nonparametric/densityorthopoly.py	`0% <0%> (ø)`	⬆️
statsmodels/sandbox/distributions/genpareto.py	`0% <0%> (ø)`	⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321619e...b65c971. Read the comment docs.

bashtage · 2019-05-29T07:45:46Z

Cleaning of very old, unloved code.

Ideally, the working examples in sm\sm\examples should be moved to notebooks in sm\examples\notebooks.

bashtage · 2019-05-29T07:47:06Z

4 years since the last non-bugfix change.

josef-pkt · 2019-05-29T13:23:06Z

statsmodels/examples/ex_generic_mle_tdist.py

-#should be replace
-# FIXME: importing these patches scipy distribution classes in-place.
-#  Don't do this.
-import statsmodels.sandbox.distributions.sppatch  # noqa:F401


don't change this import location
Given that this is monkey patching scipy, the location of the import is important and might change other results.

josef-pkt · 2019-05-29T13:28:09Z

those PRs need review

It's not a very productive use of time
@jbrockmendel Take one example and convert it into a notebook instead of changing things all over the place !!!

jbrockmendel · 2019-05-29T13:52:22Z

Take one example and convert it into a notebook

Awaiting comment on #5795.

josef-pkt · 2019-05-29T13:59:23Z

#5795 add it as or to a notebook for the docs and we don't have to worry about changes to the original script.
The script file then just needs to be marked for deletion if there is no extra content left.

jbrockmendel · 2019-05-29T14:04:59Z

add it as or to a notebook for the docs

Should "as or" be "as is or"? Wouldn't we want to avoid making the currently-wrong version into a notebook?

josef-pkt · 2019-05-29T14:10:10Z

I meant add it as a new notebook or add it to an existing notebook if that location is appropriate.

Based on skimming your changes, they look good, but I didn't check the details, nor what is "wrong" with the current version.
You put your version with cleanup and changes and possibly extra explanations in the notebook, but as in that PR, the existing example script files can be taken as basis for noteboooks.

REF/CLN: collect imports at top of file, de-duplicate imports

8a72644

Fixup typo

b65c971

bashtage merged commit 92885fd into statsmodels:master May 29, 2019

josef-pkt reviewed May 29, 2019

View reviewed changes

jbrockmendel deleted the E4 branch May 29, 2019 13:53

bashtage mentioned this pull request Jun 5, 2019

RLS: Release 0.10/0.11/0.next blockers and schedule #5620

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

REF/CLN: collect imports at top of file, de-duplicate imports #5805

REF/CLN: collect imports at top of file, de-duplicate imports #5805

jbrockmendel commented May 29, 2019

pep8speaks commented May 29, 2019 •

edited

coveralls commented May 29, 2019

codecov bot commented May 29, 2019

codecov bot commented May 29, 2019 •

edited

codecov bot commented May 29, 2019

bashtage commented May 29, 2019

bashtage commented May 29, 2019

josef-pkt May 29, 2019

josef-pkt commented May 29, 2019

jbrockmendel commented May 29, 2019

josef-pkt commented May 29, 2019

jbrockmendel commented May 29, 2019

josef-pkt commented May 29, 2019

REF/CLN: collect imports at top of file, de-duplicate imports #5805

REF/CLN: collect imports at top of file, de-duplicate imports #5805

Conversation

jbrockmendel commented May 29, 2019

pep8speaks commented May 29, 2019 • edited

Comment last updated at 2019-05-29 04:42:47 UTC

coveralls commented May 29, 2019

codecov bot commented May 29, 2019

Codecov Report

codecov bot commented May 29, 2019 • edited

Codecov Report

codecov bot commented May 29, 2019

Codecov Report

bashtage commented May 29, 2019

bashtage commented May 29, 2019

josef-pkt May 29, 2019

Choose a reason for hiding this comment

josef-pkt commented May 29, 2019

jbrockmendel commented May 29, 2019

josef-pkt commented May 29, 2019

jbrockmendel commented May 29, 2019

josef-pkt commented May 29, 2019

pep8speaks commented May 29, 2019 •

edited

codecov bot commented May 29, 2019 •

edited