Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Warn rather than print #5848

Merged
merged 1 commit into from Jun 8, 2019
Merged

Conversation

bashtage
Copy link
Member

@bashtage bashtage commented Jun 8, 2019

Warn users abotu convergence rather than priting a message

closes #3794

Warn users abotu convergence rather than priting a message

closes statsmodels#3794
@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #5848 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5848      +/-   ##
=========================================
+ Coverage    82.5%   82.5%   +<.01%     
=========================================
  Files         597     597              
  Lines       94145   94146       +1     
  Branches    10401   10401              
=========================================
+ Hits        77671   77672       +1     
  Misses      14056   14056              
  Partials     2418    2418
Impacted Files Coverage Δ
statsmodels/base/l1_solvers_common.py 68.75% <100%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d2fcb...e348d5b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #5848 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5848      +/-   ##
=========================================
+ Coverage    82.5%   82.5%   +<.01%     
=========================================
  Files         597     597              
  Lines       94145   94146       +1     
  Branches    10401   10401              
=========================================
+ Hits        77671   77672       +1     
  Misses      14056   14056              
  Partials     2418    2418
Impacted Files Coverage Δ
statsmodels/base/l1_solvers_common.py 68.75% <100%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d2fcb...e348d5b. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 85.038% when pulling e348d5b on bashtage:l1-print-warning into 39d2fcb on statsmodels:master.

@bashtage bashtage merged commit 46db3d7 into statsmodels:master Jun 8, 2019
@bashtage bashtage deleted the l1-print-warning branch June 8, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG/REF: discrete fit_regularized uses print instead of warning
2 participants