Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/TST: minor fixes for holtwinters simulate #6631

Merged

Conversation

s-scherrer
Copy link
Contributor

Just two very small additions to #6560:

  • I fixed the alignment of equations in the docstring of simulate
  • I saw that one of the new tests was failing. I added a seed to the RNG to prevent it from failing due to RNG randomness.

@coveralls
Copy link

coveralls commented Apr 7, 2020

Coverage Status

Coverage decreased (-0.01%) to 87.709% when pulling 55bc58a on s-scherrer:holtwinters_simulate_fixes into 73a2ed7 on statsmodels:master.

- aligned equations in docstring of simulate
- test RNG with seed, so it doesn't fail randomly
@ChadFulton
Copy link
Member

Unrelated CI errors. This looks good, thanks!

@ChadFulton ChadFulton merged commit 1ccd5cd into statsmodels:master Apr 10, 2020
@bashtage bashtage added this to the 0.12 milestone Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants