Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG\ENH: Improve missing value handling in PCA #6705

Merged
merged 2 commits into from May 14, 2020

Conversation

bashtage
Copy link
Member

Improve missing value handling
Ensure a warning is correctly raised when using GLS weights if needed

closes #6483

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in master and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/master -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

@coveralls
Copy link

coveralls commented May 13, 2020

Coverage Status

Coverage increased (+0.03%) to 87.794% when pulling 903d7bc on bashtage:missing-pca into 4f77089 on statsmodels:master.

Improve missing value handling
Ensure a warning is correctly raised when using GLS weights if needed

closes statsmodels#6483
@bashtage bashtage force-pushed the missing-pca branch 3 times, most recently from 2100111 to fd7e267 Compare May 13, 2020 22:42
Fix new flake8 issues
Skip "l" variable name rule
@bashtage bashtage merged commit 89c50d1 into statsmodels:master May 14, 2020
@bashtage bashtage deleted the missing-pca branch May 14, 2020 07:03
@bashtage bashtage added this to the 0.12 milestone Jul 27, 2020
@bashtage bashtage changed the title BUG\ENH: Improve missing value handeling in PCA BUG\ENH: Improve missing value handling in PCA Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing values in PCA
2 participants