Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Refactor factor tests again #6868

Merged
merged 1 commit into from Jul 9, 2020

Conversation

bashtage
Copy link
Member

@bashtage bashtage commented Jul 9, 2020

Refactor tests to prevent random failures

  • closes #xxxx
  • tests added / passed.
  • code/documentation is well formatted.
  • properly formatted commit message. See
    NumPy's guide.

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in master and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/master -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

@coveralls
Copy link

coveralls commented Jul 9, 2020

Coverage Status

Coverage increased (+0.007%) to 88.03% when pulling 233f044 on bashtage:test-factor-again into 452f8dc on statsmodels:master.

Refactor tests to prevent random failures
@bashtage bashtage merged commit 0538c0c into statsmodels:master Jul 9, 2020
@bashtage bashtage deleted the test-factor-again branch July 9, 2020 08:48
@bashtage bashtage added this to the 0.12 milestone Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants