Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF/DOC docs and refactor of recent stats #6872

Merged
merged 4 commits into from Jul 10, 2020
Merged

REF/DOC docs and refactor of recent stats #6872

merged 4 commits into from Jul 10, 2020

Conversation

josef-pkt
Copy link
Member

cleaning up recent stats additions

@josef-pkt josef-pkt added this to the 0.12 milestone Jul 9, 2020
@coveralls
Copy link

coveralls commented Jul 9, 2020 •
edited

Coverage Status

Coverage decreased (-0.0004%) to 88.031% when pulling 360129e on josef-pkt:doc_stats into 008d5fe on statsmodels:master.

@josef-pkt
Copy link
Member Author

josef-pkt commented Jul 9, 2020 •
edited

samplesize_proportions_2indep_onetail ? problem writing docstring
Does it return nobs1 or a total nobs?
Is ratio argument the risk ratio or the nobs ratio ?

  1. nobs1, unit tests compare with power_proportions_2indep which uses nobs1 as argument
  2. has to be nobs ratio, because alternative is specified with diff, i.e. risk difference

@josef-pkt
Copy link
Member Author

merging, so I see the rendered docs

TBC

@josef-pkt josef-pkt merged commit 79c51ff into statsmodels:master Jul 10, 2020
@josef-pkt josef-pkt deleted the doc_stats branch February 21, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp-docs comp-stats type-refactor
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josef-pkt @coveralls