Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow custom bandwidth functions in KDEUnivariate fit #6997

Closed
wants to merge 2 commits into from

Conversation

dbivolaru
Copy link
Contributor

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in master and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/master -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

@pep8speaks
Copy link

pep8speaks commented Aug 26, 2020

Hello @dbivolaru! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-27 01:59:56 UTC

@bashtage
Copy link
Member

The docstring needs to be updated to reflect that a callable is acceptable, and what the signature of the callable should be.

Copy link
Member

@bashtage bashtage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed, especially to the docstring.

statsmodels/nonparametric/kde.py Outdated Show resolved Hide resolved
statsmodels/nonparametric/kde.py Outdated Show resolved Hide resolved
statsmodels/nonparametric/tests/test_kde.py Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 26, 2020

Coverage Status

Coverage increased (+0.01%) to 88.331% when pulling 62c940f on dbivolaru:master into 1e6b7c6 on statsmodels:master.

Copy link
Member

@bashtage bashtage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bashtage bashtage added the superseded Used for PRs with content that is superseded by a newer PR label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-nonparametric superseded Used for PRs with content that is superseded by a newer PR type-enh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Let users set KDE bandwidth use a user-defined bandwidth function
4 participants