Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Ensure summary can print with NaNs #7064

Merged
merged 1 commit into from Mar 18, 2021

Conversation

bashtage
Copy link
Member

Prevent Nans from breaking the summary

  • closes #xxxx
  • tests added / passed.
  • code/documentation is well formatted.
  • properly formatted commit message. See
    NumPy's guide.

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in master and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/master -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 88.338% when pulling e4e7777 on bashtage:summary-nan-exp-smooth into 0376f69 on statsmodels:master.

@josef-pkt
Copy link
Member

Why don't you return " nan" instead of empty? or use repr(x) or str(x)

Are there no cases where users should be alerted to nans?

I don't know the code here.

@josef-pkt josef-pkt mentioned this pull request Jan 25, 2021
15 tasks
@ChadFulton ChadFulton added this to the 0.12.2 milestone Feb 1, 2021
Prevent Nans from breaking the summary
@bashtage bashtage merged commit 6d4d588 into statsmodels:master Mar 18, 2021
@bashtage bashtage deleted the summary-nan-exp-smooth branch March 18, 2021 18:08
bashtage added a commit to bashtage/statsmodels that referenced this pull request Mar 22, 2021
@bashtage bashtage removed the backport label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants