BUG: raise if non-binary endog in Probit #7229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #7210 Probit does not support continuous interval data
this PR adds the binary check to Probit and raises for non 0-1 endog.
I didn't change loglike of Logit which is incorrect for continuous data, everything else in Logit seems fine
(changing loglike in Logit will add possible problems with 0 log 0, so refactoring needs to be more careful)