Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Protect against future pandas changes #7844

Merged
merged 1 commit into from Nov 5, 2021

Conversation

bashtage
Copy link
Member

@bashtage bashtage commented Nov 5, 2021

CachedProperty is not property-like and uses fget rather than func

  • closes #xxxx
  • tests added / passed.
  • code/documentation is well formatted.
  • properly formatted commit message. See
    NumPy's guide.

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in main and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/main -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

CachedProperty is not property-like and uses fget rather than func
@bashtage bashtage merged commit 31feef0 into statsmodels:main Nov 5, 2021
bashtage added a commit to bashtage/statsmodels that referenced this pull request Nov 5, 2021
MAINT: Protect against future pandas changes
bashtage added a commit that referenced this pull request Nov 5, 2021
BACKPORT Merge pull request #7844 from bashtage/future-pandas
@bashtage bashtage removed the backport label Nov 5, 2021
@bashtage bashtage deleted the future-pandas branch January 8, 2022 23:43
@bashtage bashtage added this to the 0.14 milestone Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant