Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: PerfectSeparation, warn by default instead of raise, GLM, discrete #8552

Merged
merged 1 commit into from Dec 7, 2022
Merged

REF: PerfectSeparation, warn by default instead of raise, GLM, discrete #8552

merged 1 commit into from Dec 7, 2022

Conversation

josef-pkt
Copy link
Member

closes #2680

currently defaults to warning instead of raising exception
I didn't add raise_on_perfect_prediction attribute to GLM. It is in discrete but with raising exception as default

I'm not sure yet if I keep this default and implementation

@josef-pkt josef-pkt added this to the 0.14 milestone Dec 2, 2022
@josef-pkt
Copy link
Member Author

there is also #1880 for making link check optional
That would fit in this PR

@josef-pkt
Copy link
Member Author

making link checks optional will cause merge conflicts with #8547
skip that for now and merge

@josef-pkt josef-pkt merged commit 4a2c237 into statsmodels:main Dec 7, 2022
@josef-pkt josef-pkt mentioned this pull request Dec 9, 2022
Open
@mwaskom mwaskom mentioned this pull request May 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backwards-incompat comp-discrete comp-genmod type-refactor
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

ENH: option to disable GLM Perfect Separation exception
1 participant
@josef-pkt