Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional metric added based on the quasi-likekilhood loss function (qlike). #8715

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edjanga
Copy link

@edjanga edjanga commented Mar 3, 2023

  • closes #xxxx
  • tests added / passed.
  • code/documentation is well formatted.
  • properly formatted commit message. See
    NumPy's guide.

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in main and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/main -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

@josef-pkt
Copy link
Member

something wrong here
Many unrelated changes, several look like they are reverting previous PRs and would reintroduce bugs or revert enhancements.

@josef-pkt
Copy link
Member

Do you have a reference for this definition of quasi-likelihood?

@edjanga
Copy link
Author

edjanga commented Mar 3, 2023 via email

@edjanga
Copy link
Author

edjanga commented Mar 3, 2023 via email

@josef-pkt
Copy link
Member

The article uses qlike for volatility forecast and not for mean. equ. 16b

I'm not sure we can use the same definition.
AFAICS, this does not correspond what is usually called quasi-likelihood in GLM, including gaussian.

@josef-pkt
Copy link
Member

the qlike looks more like the quasi-likelihood for the gamma family, which would be the distribution of the variance if the underlying random variable is gaussian.

Also it looks like the definition differs from equ 35 in
Patton, Andrew J., and Kevin Sheppard. “Evaluating Volatility and Correlation Forecasts.” In Handbook of Financial Time Series, edited by Thomas Mikosch, Jens-Peter Kreiß, Richard A. Davis, and Torben Gustav Andersen, 801–38. Berlin, Heidelberg: Springer, 2009. https://doi.org/10.1007/978-3-540-71297-8_36.

Also if it's used for forecasting, then it should be an out of sample evaluation measure.

I'm just skimming a few things

@bashtage any comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants