ENH: plot prediction curve over scatter in GLMGamResults.plot_partial #8881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josef-pkt
reviewed
May 16, 2023
| @@ -319,7 +319,7 @@ def plot_partial(self, smooth_index, plot_se=True, cpr=False, | |||
| If plot_se is true, then the confidence interval for the linear | |||
| prediction will be added to the plot. | |||
| cpr : bool | |||
| If cpr (component plus residual) is true, the a scatter plot of | |||
| If cpr (component plus residual) is true, them a scatter plot of | |||
|
Thanks for the PR, amend and force push would get the cleanest commit |
I've fixed the typo. Do you want to merge this change? |
|
Thanks for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when called with
cpr=True,GLMGamResults.plot_partialwill plot the scatter of residuals over the fitted curve:The change plots the curve over the scatter and reduces the marker size:
