Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip_hessian True now works in ConditionalLogit #9181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Davidvandijcke
Copy link

The skip_hessian option did not work in ConditionalLogit.fit() because the ConditionalResults function tried to retrieve cov_params() from LikelihoodModel.fit() results.

@pep8speaks
Copy link

Hello @Davidvandijcke! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 124:1: W293 blank line contains whitespace

@josef-pkt
Copy link
Member

josef-pkt commented Mar 26, 2024

the fix looks correct to me, but I'm not familiar with the internals of these models.

Thanks for finding this and the PR

In general, skip_hessian was mainly introduced for internal use to avoid computing the hessian or cov_params more than once. I guess it's never directly unit tested.

@Davidvandijcke
Copy link
Author

That makes sense. For researchers, it can be a useful option for inspecting coefficient values in large models without having to compute the Hessian every time -- which can take many times longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants