add CommunityVault contract #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
reviewed
Nov 28, 2023
| amounts[0] = 1; | ||
| amounts[1] = 1; | ||
|
|
||
| vm.prank(accounts[0]); |
There was a problem hiding this comment.
The test contract itself is going to be msg.sender by default, so no vm.prank() needed here.
There was a problem hiding this comment.
I would prefer to have it explicitly written in case we change the way we deploy in the future, wdyt?
There was a problem hiding this comment.
That's perfectly fine. Was not an actionable comment.
0xb337r007
force-pushed
the
community-vault
branch
from
c071b8a
to
45c3ca5
Compare
0xb337r007
force-pushed
the
community-vault
branch
from
7d8d74f
to
48b6ca7
Compare
|
@0xb337r007 this LGTM! I'd just ask you to squash the commits as we don't need to have the steps where stuff didn't get past the linter etc. |
|
@0x-r4bbit cool I squashed and merged it |
|
I did it directly here in UI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made in your pull request here.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?