chore: introduce certora specs for CommunityTokenDeployer #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some basic specs for the `CommunityTokenDeployer` and its interaction with `CommunityOwnerTokenRegistry`.
0x-r4bbit
commented
Jan 10, 2024
| address factoryAfter = masterTokenFactory(); | ||
|
|
||
| assert factoryBefore != factoryAfter => e.msg.sender == owner(); | ||
| } |
There was a problem hiding this comment.
Please review these and let me know if you know any other ways or specs to add here.
Properties can be found here https://notes.status.im/s/291mb-8nA
package.json
Outdated
| @@ -23,7 +23,7 @@ | |||
| "scripts": { | |||
| "clean": "rm -rf cache out", | |||
| "lint": "pnpm lint:sol && pnpm prettier:check", | |||
| "verify": "certoraRun certora/certora.conf", | |||
| "verify": "certoraRun certora/CommunityTokenDeployer.conf", | |||
There was a problem hiding this comment.
This needs to be changed.
Right now this drops the run of the original CollectibleV1 specs.
We should rather extend this so that pnpm verify runs any specs provided in the certora folder.
There was a problem hiding this comment.
Addressed this with 7704125 which now introduces pnpm verify:sub_commands which can be run individually, while still being able to run pnpm verify for all specs on CI.
This is done to allow execution of multiple verifications per command, such that we can still use `pnpm verify` as usual to run all specs, but also target individual specs using `pnpm verify:sub_command`.
0x-r4bbit
force-pushed
the
feat/certora-rules
branch
from
7704125
to
5debe57
Compare
gravityblast
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some basic specs for the
CommunityTokenDeployerand its interaction withCommunityOwnerTokenRegistry.Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?pnpm verify?