Conversation
Hey @jakubgs, and thank you so much for making your first pull request in ideas! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2
|
## What exactly we going to do? | ||
|
||
- Verify all of our dependencies are frozen and versioned (`Gemfile.lock`) | ||
- Verify we depend on no resources pulled from internet during build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it about resources from Internet which we do not control or about any resources? For example, desktop builds status-go
by doing git clone
on-the-go for specific revision. Usually, there is no issue with doing that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakubgs, during desktop mac build we also download a prepopulated zip file with libraries and frameworks needed to create StatusIm.dmg
. Currently, it is stored in a separate github repository. Where should it be stored for a deterministic build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that we should be able to automate creation process of prepopulated zip file content. The main concern is ubuntu_server
binary with modified realm
node-js module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
success-metrics: yes | ||
clear-roles: yes | ||
future-iterations: yes | ||
roles-needed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it'd be useful to have Clojure/Go devs, or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And perhaps security @corpetty as well, not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, definiely.
ideas/282-deterministic-builds.md
Outdated
|
||
## Timeline / Checkpoints | ||
|
||
__TODO__: Not sure? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's something reasonable that can be done in first iteration? Perhaps something like find out current state of each sub package/component and what biggest blockers are. This way the work can be distributed, so someone might look into JS vendoring, and someone else figuring out how to get out timestamps from some ObjC linked monster config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds reasonable, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, added some comments.
One idea is to ask Clojure/Go people in #core to see if they want to help out with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see so many people committed to this
This can be merged right? Are there more people who want to review? What's the plan for starting it? the timeline/checkpoints seems a bit fuzzy (maybe on purpose) |
A way to measure success here would be that apk is available on f-droid - this ensures that someone else can reproduce our build: https://f-droid.org/en/docs/FAQ_-_App_Developers/#will-my-app-be-built-from-source |
e26c7fa
to
aa5f5bd
Compare
I've added another interested person(@antdanchenko ), I also talked to people interested and we might have to wait a few weeks to start with this for real. |
Hi everyone, I’d like to be apart of this effort. I’m really interested in this because:
I can help here by coordinating with core contributors/marketing/UX/community resources to get people excited about deterministic builds and work to improve the users process of knowing their build is deterministic. |
Please help me to complete this. Not sure what I'm missing, this is the first idea definition I've created.