Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.25.0 #891

Closed
6 tasks done
fryorcraken opened this issue Aug 17, 2022 · 4 comments
Closed
6 tasks done

Release 0.25.0 #891

fryorcraken opened this issue Aug 17, 2022 · 4 comments
Assignees
Projects

Comments

@fryorcraken
Copy link
Collaborator

fryorcraken commented Aug 17, 2022

Track the blockers for the next release.

A lot of refactoring has happen since the last release:

  • Migration to ESM only
  • Upgrade to latest libp2p* libraries
  • New API for a more modular architecture

Release candidates under the next flag will be published to help prepare this release.

Tasks

Remaining tasks to do before release

@fryorcraken fryorcraken added this to New in js-waku Aug 17, 2022
@fryorcraken
Copy link
Collaborator Author

feedback from @filoozom

On latest master, it seems a bit difficult to import createWaku.
import { createWaku, CreateOptions } from 'js-waku/dist/lib/create_waku' works for types, but one needs to use import { createWaku, CreateOptions } from 'js-waku/lib/create_waku' for the imports to actually work.
Also, it's not quite clear how to connect to static peers., as I can't import PeerDiscoveryStaticPeers (maybe related to the same issue as for createWaku)

@fryorcraken fryorcraken moved this from New to In Progress in js-waku Aug 17, 2022
@fryorcraken fryorcraken self-assigned this Aug 17, 2022
@fryorcraken fryorcraken changed the title Release 0.25.0 @waku/core release 0.1.0 Aug 17, 2022
@fryorcraken fryorcraken changed the title @waku/core release 0.1.0 Release 0.25.rc-0 Aug 17, 2022
@fryorcraken
Copy link
Collaborator Author

#893 helps with the proto behaviour

status-bors-ng bot added a commit that referenced this issue Aug 17, 2022
892: fix: type export via `typesVersions` r=fryorcraken a=filoozom

## Problem

Importing anything from TypeScript in `js-waku/lib/` (`v0.25.0-rc.0`) does not work. It can't find the types despite the `exports.*.types` in `package.json`.

## Solution

This solution was inspired by `libp2p` ([example in ``@libp2p/interfaces`](https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interfaces/package.json#L24-L39)),` and just adds `typesVersions` to `package.json`.

Documentation: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#folder-redirects-using-

## Notes

- See #891 (comment)


893: fix: do not throw on lack of response r=fryorcraken a=fryorcraken

Expected proto3 behaviour, just no message returned.

Co-authored-by: Philippe Schommers <philippe@schommers.be>
Co-authored-by: fryorcraken.eth <git@fryorcraken.xyz>
@fryorcraken
Copy link
Collaborator Author

export issue #894

status-bors-ng bot added a commit that referenced this issue Aug 17, 2022
892: fix: type export via `typesVersions` r=fryorcraken a=filoozom

## Problem

Importing anything from TypeScript in `js-waku/lib/` (`v0.25.0-rc.0`) does not work. It can't find the types despite the `exports.*.types` in `package.json`.

## Solution

This solution was inspired by `libp2p` ([example in ``@libp2p/interfaces`](https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interfaces/package.json#L24-L39)),` and just adds `typesVersions` to `package.json`.

Documentation: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#folder-redirects-using-

## Notes

- See #891 (comment)


Co-authored-by: Philippe Schommers <philippe@schommers.be>
status-bors-ng bot added a commit that referenced this issue Aug 19, 2022
892: fix: type export via `typesVersions` r=fryorcraken a=filoozom

## Problem

Importing anything from TypeScript in `js-waku/lib/` (`v0.25.0-rc.0`) does not work. It can't find the types despite the `exports.*.types` in `package.json`.

## Solution

This solution was inspired by `libp2p` ([example in ``@libp2p/interfaces`](https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interfaces/package.json#L24-L39)),` and just adds `typesVersions` to `package.json`.

Documentation: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#folder-redirects-using-

## Notes

- See #891 (comment)


Co-authored-by: Philippe Schommers <philippe@schommers.be>
@fryorcraken fryorcraken changed the title Release 0.25.rc-0 Release 0.25.0 Aug 24, 2022
@fryorcraken
Copy link
Collaborator Author

Done!

js-waku automation moved this from In Progress to Done Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant