fix: type export via typesVersions
#892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fryorcraken
force-pushed
the
fix/types-exports
branch
from
9b78314
to
2a8d82b
Compare
fryorcraken
approved these changes
Aug 17, 2022
|
bors merge |
status-bors-ng bot
added a commit
that referenced
this pull request
Aug 17, 2022
892: fix: type export via `typesVersions` r=fryorcraken a=filoozom ## Problem Importing anything from TypeScript in `js-waku/lib/` (`v0.25.0-rc.0`) does not work. It can't find the types despite the `exports.*.types` in `package.json`. ## Solution This solution was inspired by `libp2p` ([example in ``@libp2p/interfaces`](https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interfaces/package.json#L24-L39)),` and just adds `typesVersions` to `package.json`. Documentation: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#folder-redirects-using- ## Notes - See #891 (comment) 893: fix: do not throw on lack of response r=fryorcraken a=fryorcraken Expected proto3 behaviour, just no message returned. Co-authored-by: Philippe Schommers <philippe@schommers.be> Co-authored-by: fryorcraken.eth <git@fryorcraken.xyz>
|
This PR was included in a batch that timed out, it will be automatically retried |
status-bors-ng bot
added a commit
that referenced
this pull request
Aug 17, 2022
892: fix: type export via `typesVersions` r=fryorcraken a=filoozom ## Problem Importing anything from TypeScript in `js-waku/lib/` (`v0.25.0-rc.0`) does not work. It can't find the types despite the `exports.*.types` in `package.json`. ## Solution This solution was inspired by `libp2p` ([example in ``@libp2p/interfaces`](https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interfaces/package.json#L24-L39)),` and just adds `typesVersions` to `package.json`. Documentation: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#folder-redirects-using- ## Notes - See #891 (comment) Co-authored-by: Philippe Schommers <philippe@schommers.be>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Required status check \"size\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
fryorcraken
force-pushed
the
fix/types-exports
branch
from
2a8d82b
to
5137f28
Compare
|
Canceled. |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Importing anything from TypeScript in
js-waku/lib/(v0.25.0-rc.0) does not work. It can't find the types despite theexports.*.typesinpackage.json.Solution
This solution was inspired by
libp2p(example in@libp2p/interfaces), and just addstypesVersionstopackage.json.Documentation: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#folder-redirects-using-
Notes