more work on the BN/VC split #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
onqtam
commented
May 27, 2020
•
onqtam
commented
- fixed comments from the last review
- getting more data to the VC via RPC, moved some code back into the BN only
- block proposal and attestation duties being requested as well
- fixed comments from the last review - getting more data VIA RPC, moved some code back into the BN only - attestation duties being requested as well
onqtam
commented
May 27, 2020
| @@ -61,6 +62,58 @@ declareHistogram beacon_attestation_received_seconds_from_slot_start, | |||
|
|
|||
| logScope: topics = "beacnde" | |||
|
|
|||
| proc getStateFromSnapshot(conf: BeaconNodeConf): NilableBeaconStateRef = | |||
There was a problem hiding this comment.
This has been moved back in here because it's no longer needed by the VC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.