Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump modules to deal with the Nim 1.2 upgrade #829

Merged
merged 12 commits into from
Apr 8, 2020
Merged

Conversation

zah
Copy link
Member

@zah zah commented Mar 24, 2020

Work in progress. Many modules don't compile yet.

@zah zah mentioned this pull request Mar 24, 2020
@arnetheduck
Copy link
Member

this is wip/don't merge though until 1.2 is released?

@zah
Copy link
Member Author

zah commented Mar 24, 2020

Yes (the submodules bumped here are the ones that already work fine with 1.2)

@zah zah force-pushed the nim-1.2 branch 3 times, most recently from 2d9028b to 28e1581 Compare March 25, 2020 18:07
@tersec
Copy link
Contributor

tersec commented Mar 27, 2020

To what extent do the bumped modules also work with Nim 1.0.6?

@zah
Copy link
Member Author

zah commented Mar 27, 2020

I've tried to make sure that everything with merged commits to master also works in 1.0.6. Some submodules require changes specific to Nim 1.2 and I've created branches named nim-1.2 in all such submodules.

@jangko
Copy link
Contributor

jangko commented Apr 6, 2020

this is the error message from CI

[Suite] Official - Sanity - Slots  [Preset: minimal]
D:\a\1\s\vendor\nimbus-build-system\vendor\Nim\lib\system\fatal.nim(49) sysFatal

    Unhandled exception: D:\a\1\s\tests\helpers\debug_state.nim(51, 13) `stateRef.slot == postRef.slot` 
Diff: stateRef.slot = 226486149642715137
and   postRef.slot = 16
 [AssertionError]

and this is what I get locally:

[Suite] Official - Sanity - Slots  [Preset: minimal]
F:\projects\status-beacon-chain\vendor\nimbus-build-system\vendor\Nim\lib\system\fatal.nim(49) sysFatal

    Unhandled exception: F:\projects\status-beacon-chain\tests\helpers\debug_state.nim(51, 13) `stateRef.slot == postRef.slot`
Diff: stateRef.slot = 465826127085043713
and   postRef.slot = 16
 [AssertionError]

similar error but the stateRef.slot value is different. is this something expected? I'm a bit confused.

same thing happened to [Preset: mainnet]

# CI value:
Diff: stateRef.slot = 302484994650013697
and   postRef.slot = 64

# local value
Diff: stateRef.slot = 9397289341572612097
and   postRef.slot = 64

@stefantalpalaru
Copy link
Contributor

stefantalpalaru commented Apr 6, 2020

Heap corruption on 32-bit?

64-bit Linux also shows different slot values (added debug prints locally): (I was printing the slots before process_slots())

@stefantalpalaru
Copy link
Contributor

stefantalpalaru commented Apr 6, 2020

It's not Windows specific. 64-bit Linux host targetting 32-bit:

[amd] 38 Mon Apr 06 20:51:46 |/mnt/sda3/storage/CODE/status/nim-beacon-chain-clean|
stefan$ NIMTEST_ABORT_ON_ERROR=1 ./env.sh nim c -r -f -d:disableLibbacktrace --cpu:i386 --passC:"-m32" --passL:-m32 --verbosity:0 --hints:off tests/official/test_fixture_sanity_slots.nim

[Suite] Official - Sanity - Slots  [Preset: minimal]
stateRef.slot = 6225646707204423685
postRef.slot = 12
/mnt/sda3/storage/CODE/status/nim-beacon-chain-clean/tests/official/test_fixture_sanity_slots.nim(51) test_fixture_sanity_slots
/mnt/sda3/storage/CODE/status/nim-beacon-chain-clean/tests/official/test_fixture_sanity_slots.nim(47) runTest
/mnt/sda3/storage/CODE/status/nim-beacon-chain-clean/tests/helpers/debug_state.nim(51) testImpl_slots_identifier
/mnt/sda3/storage/CODE/status/nim-beacon-chain-clean/vendor/nimbus-build-system/vendor/Nim/lib/system/assertions.nim(29) failedAssertImpl
/mnt/sda3/storage/CODE/status/nim-beacon-chain-clean/vendor/nimbus-build-system/vendor/Nim/lib/system/assertions.nim(22) raiseAssert
/mnt/sda3/storage/CODE/status/nim-beacon-chain-clean/vendor/nimbus-build-system/vendor/Nim/lib/system/fatal.nim(49) sysFatal

    Unhandled exception: /mnt/sda3/storage/CODE/status/nim-beacon-chain-clean/tests/helpers/debug_state.nim(51, 13) `stateRef.slot == postRef.slot` 
Diff: stateRef.slot = 6225646707204423685
and   postRef.slot = 12
 [AssertionError]
[FAILED] Slots - over_epoch_boundary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants