Introduce multiple BLS backend support: BLST and Milagro #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2020
Closed
mratsim
pushed a commit
that referenced
this pull request
Jul 27, 2021
In #100 a regression was introduced to BLST `fastAggregateVerify`. Previous code: ``` var aggAffine{.noInit.}: PublicKey aggAffine.point.blst_p1_to_affine(aggregate) return coreVerifyNoGroupCheck(aggAffine, message, signature, DST) ``` New code introducing regression: ``` var aggAffine{.noInit.}: PublicKey aggAffine.finish(aggAffine) return coreVerifyNoGroupCheck(aggAffine, message, signature, DST) ``` This change led to a compilation error when using `fastAggregateVerify` with proof-of-possession. Secondly, `aggregateVerify` with proof-possession also fails to compile. This was never working, ever since BLST support was introduced in #68. Problematic code: ``` if publicKeys.len != proofs.len or publicKeys != messages.len: return false ``` This patch addresses both compilation problems and extends the existing tests to also cover proof-of-possession functionality. Because the Eth2 vectors do not include proof-of-possession data, the test generator was temporarily extended to produce such reference data. A copy of that data is hardcoded in the eth2_vectors tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds BLST as an alternative backend, complete with EIP2333 support (which requires importing BLST internals).
The code is using an older version of BLST, the same that was using in the proof-of-concept https://github.com/status-im/nim-blst repo. The changes are an API change for aggregation.
The code does not use multithreaded miller loops for aggregate verification like the Rust/Go code see:
Miracl/BLST can be switched with
-d:BLS_BACKEND=miracl/-d:BLS_BACKEND=blst/-d:BLS_BACKEND=auto,autois default