feature: suggest nearest match if user give unrecognized option #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similar to git `Did you mean '...'?`, this feature put `std/editDistance` into action help users to quickly recognize his error instead of plain `Unrecognized option '...'.`
|
It would be better if we set some maximum allowed distance for suggesting an alternative. |
|
If I understand correctly, does it mean we need to prevent the algorithm from giving a suggestion that is too far from what asked by user so it looks completely unrelated? Yes I observed sometime the algorithm give ridiculous feedback. |
|
Yes, exactly. I think edit distance of 3 or 4 is the maximum reasonable one (but you can try different values to get idea how it works). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to git
Did you mean '...'?, this feature putstd/editDistanceinto action and help users to quickly recognize his error instead of plain
Unrecognized option '...'.