use correct exception in parseCmdArg
#614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`parseCmdArg` is expected to raise `ValueError` but for `enr.Record`, `Node`, `PrivateKey`, and `NatConfig`, we raise `ConfigurationError`. Change to `ValueError` instead.
|
Nim devel error was already present before this PR: |
|
Nim 1.6 error was already present before this PR: This is due to recent |
kdeme
approved these changes
May 31, 2023
Right, something I'll have to look into :) |
Merged
arnetheduck
reviewed
Jun 7, 2023
| # at your option. | ||
| # This file may not be copied, modified, or distributed except according to | ||
| # those terms. | ||
|
|
There was a problem hiding this comment.
should probably have slapped push raises: [] on top here
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Feb 17, 2024
Status Nim style mandates `{.push raises: []}.` at start of modules.
Ensure that's the case so that exceptions are properly tracked.
- https://status-im.github.io/nim-style-guide/errors.exceptions.html
- status-im/nim-eth#614 (comment)
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Feb 17, 2024
Status Nim style mandates `{.push raises: []}.` at start of modules.
Add a CI task to ensure exceptions keep getting properly tracked.
- https://status-im.github.io/nim-style-guide/errors.exceptions.html
- status-im/nim-eth#614 (comment)
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Feb 18, 2024
Status Nim style mandates `{.push raises: []}.` at start of modules.
Ensure that's the case so that exceptions are properly tracked.
- https://status-im.github.io/nim-style-guide/errors.exceptions.html
- status-im/nim-eth#614 (comment)
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Feb 19, 2024
Status Nim style mandates `{.push raises: []}.` at start of modules.
Add a CI task to ensure exceptions keep getting properly tracked.
- https://status-im.github.io/nim-style-guide/errors.exceptions.html
- status-im/nim-eth#614 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parseCmdArgis expected to raiseValueErrorbut forenr.Record,Node,PrivateKey, andNatConfig, we raiseConfigurationError. Change toValueErrorinstead.