More proper client closing code

status-im · Apr 6, 2021 · 7a9d118 · 7a9d118
1 parent 64d40d6
commit 7a9d118
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/json_rpc/clients/socketclient.nim b/json_rpc/clients/socketclient.nim
@@ -63,5 +63,7 @@ proc connect*(client: RpcSocketClient, address: string, port: Port) {.async.} =
   client.loop = processData(client)
 
 method close*(client: RpcSocketClient) {.async.} =
-  # TODO: Stop the processData loop
-  await client.transport.closeWait()
+  await client.loop.cancelAndWait()
+  if not client.transport.isNil:
+    client.transport.close()
+    client.transport = nil
diff --git a/json_rpc/clients/websocketclient.nim b/json_rpc/clients/websocketclient.nim
@@ -78,5 +78,8 @@ proc connect*(client: RpcWebSocketClient, uri: string, headers: StringTableRef =
   client.loop = processData(client)
 
 method close*(client: RpcWebSocketClient) {.async.} =
+  await client.loop.cancelAndWait()
   if not client.transport.isNil:
-    client.loop.cancel()
+    client.transport.close()
+    client.transport = nil
+