Fix silent uint64 negative conversion status-im/nimbus-eth2#1671 stat…

…us-im/nimbus-eth2#1819 (#85)
status-im · Oct 7, 2020 · 9945543 · 9945543
1 parent dff46c9
commit 9945543
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/json_rpc/jsonmarshal.nim b/json_rpc/jsonmarshal.nim
@@ -86,7 +86,13 @@ proc fromJson*(n: JsonNode, argName: string, result: var int64) =
 
 proc fromJson*(n: JsonNode, argName: string, result: var uint64) =
   n.kind.expect(JInt, argName)
-  result = n.getInt().uint64
+  let asInt = n.getInt()
+  # signed -> unsigned conversions are unchecked
+  # https://github.com/nim-lang/RFCs/issues/175
+  if asInt < 0:
+    raise newException(
+      ValueError, "JSON-RPC input is an unexpected negative value")
+  result = uint64(asInt)
 
 proc fromJson*(n: JsonNode, argName: string, result: var ref int64) =
   n.kind.expect(JInt, argName)