add full gc collection every teardown #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, this doesn't seem to be the issue after all, tests still fail in the same place. |
|
|
Sure, but forcing a full collect in teardown doesn't seem to fix it, so I suspect that something else is triggering it before the full collect happens. Are we nullifying references somewhere else besides the fix from @arnetheduck in chronos? |
|
Ah sorry, forcing full collect is just to make sure it crashes 100% 😄 and avoid catching it in the future after months... |
|
This branch is not a fix, just an improvement on how tests test things basically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to the garbage collected reality