avoid implicit synthesis of CaseTransition
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transitioning the case of a case object without full reinitialization leads to undefined behaviour. Don't do such transitions implicitly, and require explicit `readValue` override for such types in those cases.
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 12, 2023
Override default Json parsing for keystore case objects to avoid `CaseTransition` logic to be emitted. When parsing the discriminator, reinitialize the entire object instead of implicitly changing it, to avoid UB and also possible oversights when extending the object. See status-im/nim-serialization#59
tersec
approved these changes
Jun 12, 2023
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 16, 2023
Override default Json parsing for keystore case objects to avoid `CaseTransition` logic to be emitted. When parsing the discriminator, reinitialize the entire object instead of implicitly changing it, to avoid UB and also possible oversights when extending the object. See status-im/nim-serialization#59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transitioning the case of a case object without full reinitialization leads to undefined behaviour. Don't do such transitions implicitly, and require explicit
readValueoverride for such types in those cases.