avoid generic versions of raising function

status-im · Jan 8, 2022 · 66745f2 · 66745f2
1 parent 868cd6f
commit 66745f2
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/ssz_serialization/codec.nim b/ssz_serialization/codec.nim
@@ -19,10 +19,16 @@ import
 export
   types
 
-func raiseMalformedSszError*(T: type, msg: string) {.raisesssz, noinline, noreturn.} =
-  const typeName = name(T)
+func reallyRaiseMalformedSszError(typeName, msg: string) {.
+    raisesssz, noinline, noreturn.} =
+  # `noinline` helps keep the C code tight on the happy path
+  # passing `typeName` in avoids generating generic copies of this function
   raise (ref MalformedSszError)(msg: "SSZ " & typeName & ": " & msg)
 
+template raiseMalformedSszError*(T: type, msg: string) =
+  const typeName = name(T)
+  reallyRaiseMalformedSszError(typeName, msg)
+
 template raiseIncorrectSize*(T: type) =
   raiseMalformedSszError(T, "incorrect size")