implement SSZ Optionals (EIP-6475) #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for SSZ optionals according to EIP-6475. https://eips.ethereum.org/EIPS/eip-6475
etan-status
commented
Feb 10, 2023
| env TEST_LANG="c" NIMFLAGS="${NIMFLAGS} --gc:refc" nimble test | ||
| env TEST_LANG="cpp" NIMFLAGS="${NIMFLAGS} --gc:refc" nimble test | ||
| if [[ "${{ matrix.branch }}" == "devel" ]]; then | ||
| echo -e "\nTesting with '--gc:orc':\n" |
There was a problem hiding this comment.
There is memory corruption going on in the new Opt/Option test cases when using devel with --gc:orc.
Switched to --gc:refc for now, and marked this in a way so that we will know when it works again (the if wrappers around the --gc:orc nimble test commands need to be removed).
Sadly, did not manage to provide minimal repro in reasonable time. Maybe something related to the lent results from Option/Opt. It affects both.
|
Going for a post-commit review on this one so that I can refer to it from an EIP (only accepts commit refs). Please still go over it and leave comments if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for SSZ optionals according to EIP-6475. https://eips.ethereum.org/EIPS/eip-6475