avoid copies - 20% hash_tree_root speedup #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use 64-byte buffer to pass a full sha256 block at a time to `digest`,
thus avoiding internal buffer copies
* avoid several unnecessary `zeroMem` calls via {.noinit.} / etc
* process blobs 64 bytes at a time instead of splitting into 32-byte
chunks
Merkle proof generation could be sped up the same way.
HTR of recent state - pre:
```
[arnetheduck@praeceps ncli]$ time ./ncli hashTreeRoot capella_state
./state.20230609.ssz
51f87eb876461ba7f3fea40e0c248b3de6db7c035501b3ec71f8449185fc0ac8
real 0m1.056s
user 0m0.942s
sys 0m0.111s
```
post:
```
[arnetheduck@praeceps ncli]$ time ./ncli hashTreeRoot capella_state
./state.20230609.ssz
51f87eb876461ba7f3fea40e0c248b3de6db7c035501b3ec71f8449185fc0ac8
real 0m0.832s
user 0m0.726s
sys 0m0.104s
```
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jul 21, 2023
* status-im/nim-ssz-serialization#53 * avoid some `zeroMem`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
digest, thus avoiding internal buffer copieszeroMemcalls via {.noinit.} / etcMerkle proof generation could be sped up the same way.
HTR of recent state - pre:
post:
Needs status-im/nim-stew#193