Modify Linux packaging-builds to include QtWebEngine #523
Assignees
Comments
|
The Dockerfile that creates the a12e/docker-qt Docker image runs this script: |
|
So we could fork it and adjust the available packages using |
|
Considering We could simply run it again in our own layer to adjust available packages with |
|
It looks like they are already setting QT_CI_PACKAGES=qt.qt5.$(echo "${QT_VERSION}" | tr -d .).${QT_PLATFORM} \So we'd have to modify it using |
|
The available packages are: |
|
I tried re-building the image by re-running the script like so: But it just got stuck on that for more than 3 hours. |
|
I tried running it with |
|
Options:
|
|
A suggestion from @richard-ramos is to add |
|
I did it like this, adding # Re-install Qt with QtWebEngine by adjusting QT_CI_PACKAGES
# The http_proxy=invalid is a fix for getting stuck on 'Welcome Page'
RUN sudo rm -r $QT_PATH \
&& sudo sed -i 's/qt.qt5/qt.qt5.5140.qtwebengine.gcc_64,qt.qt5/' /tmp/build/install-qt.sh \
&& sudo sed -i '\#^/tmp/build/bin/extract-qt-installer.*#i export http_proxy=invalid' /tmp/build/install-qt.sh \
&& VERBOSE=1 QT_VERSION=5.14.0 sudo -E /tmp/build/install-qt.shAnd it works! Lovely. |
|
I also learned that if you wan to use a different delimiter in |
|
I tried without Slightly bigger from what we use right now, which makes sense. |
jakubgs
added a commit
that referenced
this issue
Oct 6, 2020
We do this here to avoid having to fork the original image repo: https://github.com/a12e/docker-qt Resolves: #523 Signed-off-by: Jakub Sokołowski <jakub@status.im>
richard-ramos
pushed a commit
that referenced
this issue
Oct 6, 2020
We do this here to avoid having to fork the original image repo: https://github.com/a12e/docker-qt Resolves: #523 Signed-off-by: Jakub Sokołowski <jakub@status.im>
|
Something is wrong. I ran the build after removing Something is wrong with how Qt is installed. |
|
The script we run removes some useless stuff after installation: But that should not affect the |
|
More accurate list of packages: |
|
It looks like the selection needs to include Which results in a proper installation which includes |
|
Okay, this looks better: |
|
But daaaamn look at the size of the image: |
|
It appears by using: I'm also including other stuff: |
|
That's better: I think there was a bit of a red herring due to |
jakubgs
added a commit
that referenced
this issue
Oct 6, 2020
We do this here to avoid having to fork the original image repo: https://github.com/a12e/docker-qt Resolves: #523 Signed-off-by: Jakub Sokołowski <jakub@status.im>
richard-ramos
pushed a commit
that referenced
this issue
Oct 6, 2020
We do this here to avoid having to fork the original image repo: https://github.com/a12e/docker-qt Resolves: #523 Signed-off-by: Jakub Sokołowski <jakub@status.im>
|
I've updated #1126 with adjusted # Re-install Qt with QtWebEngine by adjusting QT_CI_PACKAGES
# The http_proxy=invalid is a fix for getting stuck on 'Welcome Page'
RUN sudo sed /tmp/build/install-qt.sh -i \
-e 's/^QT_CI_PACKAGES=.*/export QT_CI_PACKAGES=qt.qt5.5140.gcc_64,qt.qt5.5140.qtwebengine,qt.qt5/' \
-e '\#^/tmp/build/bin/extract-qt-installer.*#i export http_proxy=invalid' \
&& sudo -E /tmp/build/install-qt.sh@richard-ramos can you please test it with the browser branch when you have some time? |
|
Did a quick test with #1128 |
|
Rebuilding image with added |
jakubgs
added a commit
that referenced
this issue
Oct 7, 2020
We do this here to avoid having to fork the original image repo: https://github.com/a12e/docker-qt Resolves: #523 Signed-off-by: Jakub Sokołowski <jakub@status.im>
|
Looks like there's more stuff it will need: |
jakubgs
added a commit
that referenced
this issue
Oct 7, 2020
We do this here to avoid having to fork the original image repo: https://github.com/a12e/docker-qt Resolves: #523 Signed-off-by: Jakub Sokołowski <jakub@status.im>
richard-ramos
pushed a commit
that referenced
this issue
Oct 7, 2020
We do this here to avoid having to fork the original image repo: https://github.com/a12e/docker-qt Resolves: #523 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this issue
Oct 7, 2020
We do this here to avoid having to fork the original image repo: https://github.com/a12e/docker-qt Resolves: #523 Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The docker image used as the basis for building and packaging
bin/nim_status_clientis missing theQtWebEnginecomponents, which results in aAppImagethat lacks the browser.For clarity's sake, what I mean is that even if a user enables it in Advanced Settings the browser tab will be blank because the needed software components are missing.
The text was updated successfully, but these errors were encountered: