feat: add login and logout commands to example client #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsbradleyjr
force-pushed
the
feat/example-client/login-logout
branch
2 times, most recently
from
3fbc213
to
b2b5aa5
Compare
michaelsbradleyjr
force-pushed
the
feat/example-client/login-logout
branch
2 times, most recently
from
d3c013d
to
f1e782f
Compare
michaelsbradleyjr
changed the title
michaelsbradleyjr
force-pushed
the
feat/example-client/login-logout
branch
from
f1e782f
to
aa67f67
Compare
emizzle
approved these changes
Jul 7, 2021
| @@ -1,6 +1,7 @@ | |||
| CREATE TABLE IF NOT EXISTS accounts ( | |||
| keyUid VARCHAR PRIMARY KEY, | |||
| name TEXT NOT NULL, | |||
| creationTimestamp BIG INT, | |||
There was a problem hiding this comment.
Just as a general comment for this as it is something that we should revisit in the future. Instead of making schema updates in existing migrations, it may better to create a single schema sql file that we can bring up the entire DB with. Any changes to the schema can be added to the schema definition directly. Once nim-status is out in the wild, we can update existing DBs using migrations.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182 and #183.