Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toychat default content topic #583

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Conversation

jm-clius
Copy link
Contributor

This updates the toychat (chat2) default content topic to match the topic recommendation as decided upon in vacp2p/rfc#383.

For the upcoming testnet, the content topic is set to /toychat/2/huilong/proto (updated from /waku/2/huilong/proto).

cc @D4nte for parallel changes in js-waku.

@jm-clius jm-clius requested review from D4nte and oskarth May 31, 2021 09:27
@oskarth
Copy link
Contributor

oskarth commented May 31, 2021

Also @richard-ramos

D4nte added a commit to waku-org/js-waku that referenced this pull request Jun 1, 2021
examples/v2/config_chat2.nim Outdated Show resolved Hide resolved
D4nte added a commit to waku-org/js-waku that referenced this pull request Jun 2, 2021
@jm-clius jm-clius merged commit 1064181 into master Jun 2, 2021
@jm-clius jm-clius deleted the feat/chat2-content-topic branch June 2, 2021 09:05
@D4nte
Copy link
Contributor

D4nte commented Jun 2, 2021

Actually, js-waku change should not be in parallel (https://status-im.github.io/js-waku/ is deployed from master) but once new release of nim-waku is done! :) I'll keep a PR open on js-waku side and merge once 0.4 is deployed on the prod fleet.

D4nte added a commit to waku-org/js-waku that referenced this pull request Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants