nimbus-verified-proxy integration with status-go #1497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
arnetheduck
reviewed
Mar 16, 2023
| SHAREDLIBEXT = dylib | ||
| else | ||
| ifneq (, $(findstring mingw, $(OS))$(findstring cygwin, $(OS))$(findstring msys, $(OS))) | ||
| SHAREDLIBEXT = lib |
There was a problem hiding this comment.
.lib / .a are static libraries, not shared - ie shared libraries use .dll / .so - which is intended here?
There was a problem hiding this comment.
Yes, thanks for spotting, will fix. This is a partial carryover from earlier implementation that relied only on dynamic libs.
vitvly
force-pushed
the
status_go_static
branch
from
a3ed611
to
108a82f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is depended on by https://github.com/siphiuel/lc-proxy-wrapper.
Custom
nim-confutilsdependency is due to adding a fix suggested in status-im/nim-confutils#31.
Tracking issue: status-im/status-go#3282