Communities -> Permissions: missing counter when adding requirement with 1 minted token

[anastasiyaig]

Description

1. create community
2. mint a token
3. add a permission that requires to hold 1 minted token to join the community
4. check Edit permission screen
5. check Permissions screen

As result, on both mentioned screens the digit 1 is missing , which is potential confusion. I indicated clearly that i want a member to hold 1 specific token , not any amount of mentioned token

[noeliaSD]

This is on propose. It is a design decision. When there is only one collectible, the number 1 is missing, and it is only applicable for collectibles, for assets, number 1 is shown.

However, looking again into figma.. And after some refactors in the design file, I cannot see the explicit behavior of hidding number 1 for collectibles. Here, and example.

@benjthayer could you confirm which is the expected behavior?

[anastasiyaig]

sorry about that @noeliaSD ! i was not able to find it in figma as well. Lets wait for @benjthayer to clarify !

[noeliaSD]

sorry about that @noeliaSD ! i was not able to find it in figma as well. Lets wait for @benjthayer to clarify !

No problem at all!! It was clearly specified in some point but it is true that now, it isn't, or I can't find it!

[benjthayer]

Hey @anastasiyaig @noeliaSD I think whether we show the number or not is down to whether the token is a 1:1 (1 of a kind). When selecting Furbeard in the flows, the user is opting for the permission to be tied to the owner of a specific, 1 of a kind collectible. The alternate route is to select Any Cryptokitties and select a number of Cryptokitties the user must hold for the permission to apply to them.

VS.

So if the user has gone down the path of selecting Any of a collectible collection and input a number, when they review the permission, the collectible should have the same number as input when creating the permission prefixed to it. But if they go down the route of selecting a specific 1 of a kind collectible, there is no need to enter a number and no number will appear when they review the permission.

Hope that makes sense! Looping in @xAlisher who designed the flows to confirm.

[anastasiyaig]

okay for now there is no Any condition implemented, as u can see on the screen. We specifically set amount of NFT (1 or 15 or 77). Thats why i think having this specific digit matters. For the permission with Any condition we dont need to show counter assuming user has to have at least 1 NFT
@noeliaSD what do u think?

[noeliaSD]

We do already have implemented the any condition. If the collectibles list is a collection, then it should be displayed like in the cryptokitties example, with any option on top and then all the rest of items of the collection below as in the design.

We already have this bug open: #10546 where we will remove the amount selector when the collectible is a unique one.

Then, the summary here, if I'm not wrong, would be:

1. If collectible is unique (item inside a collection), number 1 will not be displayed, since it only exists 1 element of this type.
2. For the rest of cases (selecting any in a collection type or, our minted collectibles), number 1 should be displayed.

Could you confirm @benjthayer , @anastasiyaig ?

[benjthayer]

We do already have implemented the any condition. If the collectibles list is a collection, then it should be displayed like in the cryptokitties example, with any option on top and then all the rest of items of the collection below as in the design.

We already have this bug open: #10546 where we will remove the amount selector when the collectible is a unique one.

Then, the summary here, if I'm not wrong, would be:

1. If collectible is unique (item inside a collection), number 1 will not be displayed, since it only exists 1 element of this type.
2. For the rest of cases (selecting any in a collection type or, our minted collectibles), number 1 should be displayed.

Could you confirm @benjthayer , @anastasiyaig ?

Correct! Thanks @noeliaSD :)