Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account recovery shouldn't show loading state when state is complete #11163

Open
0x-r4bbit opened this issue Jun 20, 2023 · 8 comments
Open

Account recovery shouldn't show loading state when state is complete #11163

0x-r4bbit opened this issue Jun 20, 2023 · 8 comments

Comments

@0x-r4bbit
Copy link
Member

After recovering an account from seed, I ended up seeing this:

Screenshot from 2023-06-20 11-15-30

Notice that all items seem to be complete, yet I have to wait another 1.5 minutes for the app to continue.
I think we should stop the timer if we know all necessary items were loaded.

@0x-r4bbit 0x-r4bbit added bug Something isn't working E:Onboarding labels Jun 20, 2023
@caybro caybro added the ui-team label Jun 20, 2023
@caybro
Copy link
Member

caybro commented Jun 20, 2023

CC @alexjba

@noeliaSD
Copy link
Contributor

I also noticed that the timer switches from ... to a real time like this:

Screenshot 2023-06-20 at 16 43 25

@caybro
Copy link
Member

caybro commented Jun 20, 2023

I also noticed that the timer switches from ... to a real time like this:

Screenshot 2023-06-20 at 16 43 25

Looks like an elide for text too long

@caybro
Copy link
Member

caybro commented Jun 21, 2023

Default window size occludes the last item + button:

image

@0x-r4bbit
Copy link
Member Author

@caybro that's already raised in #10947

@alexjba
Copy link
Contributor

alexjba commented Jun 21, 2023

@caybro that's already raised in #10947

Would make sense to group them into 1 bug? All of them are small tweaks we need to do in the UI.

@0x-r4bbit
Copy link
Member Author

As you wish. I personally prefer separate issues for separate things. Makes tracking progress easier.
Your call.

@caybro
Copy link
Member

caybro commented May 9, 2024

Or, can I close #11163 in favor of this one?

Yes, I think so 🙂

But technically we'll still need to remove the UI delay, is's done on QML side now. So maybe keeping a separate issue for that still makes sense?

Moving to 2.31 as this issue depends on/ is blocked by status-im/status-go#5022

@caybro caybro added the blocked label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

7 participants