Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community setting pending state not updating until restart #11336

Closed
jrainville opened this issue Jun 29, 2023 · 2 comments
Closed

Community setting pending state not updating until restart #11336

jrainville opened this issue Jun 29, 2023 · 2 comments

Comments

@jrainville
Copy link
Member

Could you please do the same in Settings/Communities (in CommunitiesListPanel.qml), there is:

readonly property bool isInvitationPending: root.rootStore.isCommunityRequestPending(model.id)

which needs similar treatment :)

root.rootStore.isCommunityRequestPending(model.id) should really be a model entity, then we wouldn't need these kind of repeated hacks above :/

We have roles like model.joined, so why not model.invitationPending for the given community?

Originally posted by @caybro in #11316 (comment)

@jrainville jrainville self-assigned this Jun 29, 2023
@jrainville jrainville added this to the 0.14 milestone Jun 29, 2023
@jrainville jrainville added Communities bug Something isn't working labels Jun 29, 2023
@jrainville
Copy link
Member Author

I'll move this issue to the backlog.
The feature already works, so this is more about a refactor to improve the code.

@jrainville jrainville added refactor and removed bug Something isn't working C2 labels Jul 25, 2023
@jrainville jrainville removed their assignment Jul 25, 2023
@jrainville jrainville removed this from the 0.14 milestone Jul 25, 2023
@iurimatias iurimatias added this to the 2.29.0 Beta milestone Feb 26, 2024
@iurimatias iurimatias modified the milestones: 2.29.0 Beta, 2.30.0 Beta Mar 5, 2024
@jrainville jrainville modified the milestones: 2.30.0 Beta, 2.31.0 Beta May 15, 2024
@mprakhov mprakhov self-assigned this May 23, 2024
@mprakhov
Copy link
Contributor

was fixed/refactored in #14287

@iurimatias iurimatias modified the milestones: 2.31.0 Beta, 2.29.0 Beta May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants