Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@desktop/communities): request to join btn fixes #14287

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

mprakhov
Copy link
Contributor

@mprakhov mprakhov commented Apr 4, 2024

What does the PR do

fixes:

  • show spinner if sending a request to join in progress (waiting for a response from status-go)
  • request to join button state switching
  • cancel my request to join
  • manual accepting/rejecting requests to join
  • updated status-go

Closes:

Affected areas

Requests to join

Screenshot of functionality (including design for comparison)

Screen.Recording.2024-04-04.at.11.44.54.mov

@status-im-auto
Copy link
Member

status-im-auto commented Apr 4, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cc3c383 #1 2024-04-04 10:08:59 ~6 min tests/nim 📄log
✔️ cc3c383 #1 2024-04-04 10:10:53 ~8 min macos/aarch64 🍎dmg
✔️ cc3c383 #1 2024-04-04 10:12:22 ~10 min macos/x86_64 🍎dmg
cc3c383 #1 2024-04-04 10:14:30 ~12 min tests/ui 📄log
✔️ cc3c383 #1 2024-04-04 10:18:55 ~16 min linux/x86_64 📦tgz
✔️ cc3c383 #1 2024-04-04 10:35:13 ~32 min windows/x86_64 💿exe
cc3c383 #2 2024-04-04 10:36:08 ~11 min tests/ui 📄log
cc3c383 #3 2024-04-04 11:13:56 ~11 min tests/ui 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6591fa7 #3 2024-04-04 12:20:34 ~5 min tests/nim 📄log
✔️ 6591fa7 #3 2024-04-04 12:22:23 ~7 min macos/aarch64 🍎dmg
✔️ 6591fa7 #3 2024-04-04 12:25:32 ~10 min macos/x86_64 🍎dmg
✔️ 6591fa7 #5 2024-04-04 12:25:42 ~10 min tests/ui 📄log
✔️ 6591fa7 #3 2024-04-04 12:31:49 ~16 min linux/x86_64 📦tgz
✔️ 6591fa7 #3 2024-04-04 12:47:40 ~32 min windows/x86_64 💿exe
✔️ 89c1131 #4 2024-04-04 15:29:08 ~6 min tests/nim 📄log
✔️ 89c1131 #4 2024-04-04 15:30:16 ~7 min macos/aarch64 🍎dmg
✔️ 89c1131 #4 2024-04-04 15:33:55 ~11 min macos/x86_64 🍎dmg
✔️ 89c1131 #6 2024-04-04 15:35:29 ~13 min tests/ui 📄log
✔️ 89c1131 #4 2024-04-04 15:41:07 ~18 min linux/x86_64 📦tgz
✔️ 89c1131 #4 2024-04-04 15:55:24 ~32 min windows/x86_64 💿exe

@status-im-auto
Copy link
Member

✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-14287#1 🔹 ~6 min 45 sec 🔹 cc3c383 🔹 📦 tests/nim package

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

>>> Error loading StoryBook page: QUrl("file:///home/jenkins/workspace/s_linux_x86_64_tests-ui_PR-14287/storybook/pages/JoinCommunityViewPage.qml")

Needs fixing

@mprakhov mprakhov force-pushed the mp/issue-14179 branch 2 times, most recently from f542509 to 6591fa7 Compare April 4, 2024 12:15
@mprakhov mprakhov requested a review from kounkou April 4, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sent 'Request to join' and Cancelling pending request does not change btn state
4 participants