Add additional jenkins artefact for e2e tests for keycard on desktop

[anastasiyaig]

Description

In order to test mocked keycard lib provided by @saledjenic on desktop app , we need to have a special CI build that will include TEST_ENVIRONMENT variable set before we create a build, so the lib will be accessible using CI artefact

Values for TEST_ENVIRONMENT variable:

• true
• 1

This artefact is needed to be created for pull requests, master branch and release branch.

This build could be called somewhat %_e2e

This build is needed for all the platforms we build for, but in case the possibilities are limited, Mac x64 and Linux are preferable for now

[anastasiyaig]

@Valentina1133 @StateOf-Vlado

[jakubgs]

Thanks.

[jakubgs]

Some questions:

• Do we really want to essentially double the number of all builds?
• Is there any good reason why this can't be the default setting for already existing builds?
• What does this TEST_ENVIRONMENT variable affect? The client binary? How the app is packaged?

[jakubgs]

According to @anastasiyaig this change is related to Keycard mocking mechanism required for testing added here:

• test(env-var): add TEST_ENVIRONMENT env var for test specific changes #9312
• feat(@desktop/keycards): mock keycard library #12182

The key part is here:

status-desktop/Makefile

Lines 395 to 400 in 2c5039f

	STATUSKEYCARDGO_RULE := build-lib
	ifeq ($(TEST_ENVIRONMENT),true)
	STATUSKEYCARDGO_RULE := build-mocked-lib
	else ifeq ($(TEST_ENVIRONMENT),1)
	STATUSKEYCARDGO_RULE := build-mocked-lib
	endif

[jakubgs]

After talking to @jrainville and @saledjenic it turns out that TEST_ENVIRONMENT variable is used by the app at runtime.

The building of vendor/status-keycard-go library is affected by it by accident essentially, and should use a different variable.

I'm proposing:

• Rename TEST_ENVIRONMENT to STATUS_RUNTIME_TEST_MODE because it needs to be clear this is runtime.
• Add a USE_MOCKED_KEYCARD_LIB env variables to affect the use of build-mocked-lib target in the Makefile.

This should resolve at least some of the confusion here.