Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chats are not loading if user was kicked and restarted the app #12558

Closed
mprakhov opened this issue Oct 26, 2023 · 2 comments · Fixed by status-im/status-go#4217
Closed

Chats are not loading if user was kicked and restarted the app #12558

mprakhov opened this issue Oct 26, 2023 · 2 comments · Fixed by status-im/status-go#4217
Assignees
@jrainville
Labels
backend-team bug Something isn't working
Milestone
0.15

Comments

@mprakhov
Copy link
Contributor

Bug Report

Description

Chats are not loading if the user was kicked and restarted the app

Steps to reproduce

Screen.Recording.2023-10-26.at.19.18.01.mov

Can be healed by reopening community invite

  • Status desktop version: latest master
  • Operating System: macOS
@jrainville
Copy link
Member

Ah I know what's going on. It tries to go back to the last community it had opened, but it isn't there anymore.

IMO, we should still be spectating the community. It's probably a small bug on status-go's side. When we get kicked, we lose joined, but we should put spectacted instead.

@jrainville jrainville added this to the 0.15 milestone Oct 26, 2023
@jrainville jrainville self-assigned this Oct 26, 2023
@mprakhov
Copy link
Contributor Author

I also observe that joined status is set to true, even if I was kicked (getAmIMember)

jrainville added a commit to status-im/status-go that referenced this issue Oct 26, 2023
@jrainville
fix(community): getting kicked out of a community should still spectate
8564f1a 
Fixes status-im/status-desktop#12558

When getting kicked out of  a community, before we used to leave the community completely, but just keep the filters on.
That created a problem when reopening the app, because the community disappeared and could even create a problem in desktop where it tried to open the last opened community but it's no longer there.

The fix now is that when getting kicked out, we instead just remove ourselves from the community and set Joined to false, but we keep the community spectated.
@jrainville jrainville mentioned this issue Oct 26, 2023
Merged
jrainville added a commit to status-im/status-go that referenced this issue Oct 26, 2023
@jrainville
fix(community): getting kicked out of a community should still spectate
f96c730 
Fixes status-im/status-desktop#12558

When getting kicked out of  a community, before we used to leave the community completely, but just keep the filters on.
That created a problem when reopening the app, because the community disappeared and could even create a problem in desktop where it tried to open the last opened community but it's no longer there.

The fix now is that when getting kicked out, we instead just remove ourselves from the community and set Joined to false, but we keep the community spectated.
jrainville added a commit to status-im/status-go that referenced this issue Oct 27, 2023
@jrainville
fix(community): getting kicked out of a community should still specta…
0cac2af 
…te (#4217)

Fixes status-im/status-desktop#12558

When getting kicked out of  a community, before we used to leave the community completely, but just keep the filters on.
That created a problem when reopening the app, because the community disappeared and could even create a problem in desktop where it tried to open the last opened community but it's no longer there.

The fix now is that when getting kicked out, we instead just remove ourselves from the community and set Joined to false, but we keep the community spectated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
backend-team bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

fix(community): getting kicked out of a community should still spectate status-im/status-go
2 participants
@jrainville @mprakhov