Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Membership request pending state should be shown immediately after clicking Share your addresses to join #14179

Closed
Tracked by #13988
noeliaSD opened this issue Mar 26, 2024 · 2 comments
Closed
Tracked by #13988

Membership request pending state should be shown immediately after clicking Share your addresses to join #14179

noeliaSD opened this issue Mar 26, 2024 · 2 comments
Assignees
@mprakhov
Labels
backend-team bug Something isn't working E:Desktop Community Shared Addresses Selection Implementation of the Shared Addresses feature for joining communities and also for edits
Milestone
2.29.0 Beta

Comments

@noeliaSD
Copy link
Contributor

Description

From the following issue when the user clicks the Share your addresses to join button, there is a long pause 0:49-0:55 in the video until button text changes. Although the share addresses process takes time the state of the button in the JoinCommunityView should change automatically to Membership request pending or a loading spinner should be shown.

Screen.Recording.2024-03-15.at.9.09.53.AM.mp4
@noeliaSD noeliaSD added backend-team E:Desktop Community Shared Addresses Selection Implementation of the Shared Addresses feature for joining communities and also for edits labels Mar 26, 2024
@noeliaSD
Copy link
Contributor Author

cc: @jrainville

@noeliaSD noeliaSD mentioned this issue Mar 26, 2024
Closed
11 tasks
@jrainville jrainville added this to the 2.29.0 Beta milestone Mar 26, 2024
@jrainville jrainville added the bug Something isn't working label Mar 26, 2024
@caybro
Copy link
Member

caybro commented Mar 29, 2024

@mprakhov pls check again with latest master, I think I've fixed this already :)

This was referenced Apr 3, 2024
Closed
Merged
@mprakhov mprakhov closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mprakhov mprakhov

Labels
backend-team bug Something isn't working E:Desktop Community Shared Addresses Selection Implementation of the Shared Addresses feature for joining communities and also for edits
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.29.0 Beta
Development

No branches or pull requests
4 participants
@caybro @jrainville @noeliaSD @mprakhov