Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"View and post" permission does not have priority on "view" permissions #14209

Closed
mprakhov opened this issue Mar 28, 2024 · 0 comments · Fixed by status-im/status-go#5000 or #14237
Closed

"View and post" permission does not have priority on "view" permissions #14209

mprakhov opened this issue Mar 28, 2024 · 0 comments · Fixed by status-im/status-go#5000 or #14237
Assignees
@jrainville
Labels
backend-team bug Something isn't working E:Desktop Comm Perms and Minting MVP Misc tasks about Community permissions that are not part of another Epic, due for the MVP
Milestone
2.29.0 Beta

Comments

@mprakhov
Copy link
Contributor

Bug Report

Description

In the case where both "view and post" and "view" permissions are configured on a channel. If a member meets the requirements for "view and post" permissions but not "view" permissions then the user is shown the chat and is told they must hold tokens that they already have if they want to post.

Steps to reproduce

  1. Set up 2 permissions, "View and post" where USER 1 met the permission criteria and "View" where USER 1 not met the criteria
  2. User open channel

Expected behavior

User can view and post

Actual behavior

The user can't post

image
image

Additional Information

  • Status desktop version: 2.28.xx and master
  • Operating System: macos
@mprakhov mprakhov added bug Something isn't working backend-team labels Mar 28, 2024
@mprakhov mprakhov mentioned this issue Mar 28, 2024
Closed
@caybro caybro added the E:Desktop Comm Perms and Minting MVP Misc tasks about Community permissions that are not part of another Epic, due for the MVP label Mar 28, 2024
@jrainville jrainville added this to the 2.29.0 Beta milestone Mar 28, 2024
@jrainville jrainville self-assigned this Mar 28, 2024
@jrainville jrainville changed the title "View and post" prmission does not have priority on "view" permissions "View and post" permission does not have priority on "view" permissions Mar 28, 2024
jrainville added a commit to status-im/status-go that referenced this issue Mar 29, 2024
@jrainville
fix(manager): make both perms satisfied if viewAndPost is satisfied
ac9fa2f 
Fixes status-im/status-desktop#14209
@jrainville jrainville mentioned this issue Mar 29, 2024
Merged
jrainville added a commit that referenced this issue Mar 29, 2024
@jrainville
fix(permissions): fix view and post permission overwritten by view perm
5c298d6 
Fixes #14209
@jrainville jrainville mentioned this issue Mar 29, 2024
Merged
jrainville added a commit to status-im/status-go that referenced this issue Apr 4, 2024
@jrainville
fix(manager): make both perms satisfied if viewAndPost is satisfied
6c82a6c 
Fixes status-im/status-desktop#14209
jrainville added a commit that referenced this issue Apr 4, 2024
@jrainville
fix(permissions): fix view and post permission overwritten by view perm
7ba641f 
Fixes #14209
jrainville added a commit that referenced this issue Apr 4, 2024
@jrainville
fix(permissions): fix view and post permission overwritten by view perm
8f5efc6 
Fixes #14209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
backend-team bug Something isn't working E:Desktop Comm Perms and Minting MVP Misc tasks about Community permissions that are not part of another Epic, due for the MVP
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.29.0 Beta
3 participants
@caybro @jrainville @mprakhov