Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members list is empty on new channel #14442

Closed
glitchminer opened this issue Apr 16, 2024 · 3 comments · Fixed by #14873
Closed

Members list is empty on new channel #14442

glitchminer opened this issue Apr 16, 2024 · 3 comments · Fixed by #14873
Assignees
Labels
backend-team bug Something isn't working
Milestone

Comments

@glitchminer
Copy link
Contributor

Bug Report

Description

user 1: Create open community
user 2: View community without joining it
user 1: Add new channel
user 2: View new channel without joining community

Members list is populated when viewing other channels but not when viewing the new one.

Expected behavior

Members list to be populated for new channel

Additional Information

  • Status desktop version: 2.28.1 RC1
  • Operating System: Mac
@glitchminer glitchminer added bug Something isn't working backend-team labels Apr 16, 2024
@jrainville jrainville added this to the 2.29.0 Beta milestone May 2, 2024
@jrainville
Copy link
Member

It's possible that my refactor here helps/fixes the issue: #12595

@MishkaRogachev
Copy link
Contributor

Screenshot 2024-05-16 at 23 05 01 reproduced

@MishkaRogachev
Copy link
Contributor

Status update:

  • succeeded in reproducing the described or similar problem in several scenarios
  • In some cases the problem was that the chat sent from status-go was initially empty. I made a naive fix: fix(communities)_: naive fix for spectated communities new channels member list status-go#5190 which fixed the problem, but only on the event sender side.
  • The second set of problems is that when getting communityDescription in nim, the request for community members happens before handleCommunityUpdates and the community is added to the service. See here:
==================> getChatMembers: @[]
==================> getCommunityChat::chatId::0x033b9753d9bb8dfb8dc32a2ff516339c8a43c717711597432f6f75c89c560749425b3d2862-8c3e-4152-9d86-3b6efd93a7a3
==================> getCommunityChats::communityId::0x033b9753d9bb8dfb8dc32a2ff516339c8a43c717711597432f6f75c89c56074942
==================> looking for::chatId::0x033b9753d9bb8dfb8dc32a2ff516339c8a43c717711597432f6f75c89c560749425b3d2862-8c3e-4152-9d86-3b6efd93a7a3
==================> trying::communityChat.id::0x033b9753d9bb8dfb8dc32a2ff516339c8a43c717711597432f6f75c89c5607494241354a09-93ad-4d7f-9ce8-76513c8328cc
==================> no chat in the community with chatId: 0x033b9753d9bb8dfb8dc32a2ff516339c8a43c717711597432f6f75c89c560749425b3d2862-8c3e-4152-9d86-3b6efd93a7a3
=======================================> handleCommunityUpdates
==================> community.chats.len: 2
==================> community.chats.len: 1
==================> adding chat this members:: @[(id: "0x04cbeac08c993a815d66e2430cca359950a1a1101b069767fe6f02dae7b722e6ae9a21c40ebdbb71fd0c4da1c0eeefc2608accee684fd4a7ba0c897c250aff9c46", joined: false, role: None)]
==================> community updated: 0x033b9753d9bb8dfb8dc32a2ff516339c8a43c717711597432f6f75c89c56074942

Currently trying to delay updates before the community saved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend-team bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants